Project

General

Profile

Actions

Bug #313

closed

Setting contrast value for SmartXX V3 changes backlight when modchip detection is ON.

Added by psyko_chewbacca over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Other (un-categorized)
Target version:
Start date:
05/08/2014
Due date:
% Done:

100%

Resolution:
fixed
Affected Version:

Description

If I enable modchip detection in "advancedsettings.xml" with a SmartXX V3, changing contrast value in settings will actually change backlight value.

In "smartxxlcd.cpp" source file, you can see that both "DisplaySetBacklight"(line 414) and "DisplaySetContrast"(line 465) functions output commands to "register" 0xF701 (DISP_O_LIGHT = 0xF701)

Line 465 should be something like: _outp(DISP_O_CONTRAST, itemp);

I guess you could also ditch "itemp" variable and use "iNewLevel&127|128" int "_outp" function.

P.S.: I don't own a real SmartXX V3 but spoofing it with the modchip I currently develop exhibited the described behavior. I attached a "fixed" source file but it is untested as I don't have the necessary setup to build XBMC. I will change that soon!


Files

smartxxlcd.cpp (20.6 KB) smartxxlcd.cpp psyko_chewbacca, 05/08/2014 02:59 PM
smartxxlcd.cpp.patch (636 Bytes) smartxxlcd.cpp.patch dandar3, 09/08/2014 03:14 PM
Actions #1

Updated by dandar3 over 9 years ago

Provide .patch from psyko_chewbacca's changes.

Actions #2

Updated by buzz over 9 years ago

  • Status changed from New to Closed
  • Assignee set to buzz
  • % Done changed from 50 to 100
  • Resolution set to fixed

thanks. fixed in r32875.

Actions

Also available in: Atom PDF