Actions
Feature #314
closed
HTTP API GetShares() - allow for "programs" type
Start date:
09/08/2014
Due date:
% Done:
100%
Resolution:
fixed
Description
HTTP API GetShares() to allow for "programs" type - useful to identify "Emulators" and "Games" source locations.
Patch file attached, thanks.
Files
Updated by buzz over 9 years ago
- Status changed from New to Feedback
- Assignee set to dandar3
looks good, but is there any specific reason you inserted it in the middle of the else if and before FILES in parameter ordering rather than appending it ? Makes the patchset/changeset more readable that way.
Updated by buzz over 9 years ago
When I said parameter ordering, I meant inserting it before FILES in the enumeration, rather than adding it to the end. (apologise for poor wording)
Updated by dandar3 over 9 years ago
- File XBMChttp.cpp.patch XBMChttp.cpp.patch added
- Assignee changed from dandar3 to buzz
Thought "programs" were a bit "smarter" than "files", not important though.
Updated patch attached.
Updated by buzz over 9 years ago
- Status changed from Feedback to Closed
- % Done changed from 0 to 100
- Resolution set to fixed
applied in r32872. Thanks
Actions