Project

General

Profile

Actions

Bug #188

closed

Trailing quote not being trimmed from path when read from favourites

Added by wannabegt4 almost 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
arnova
Category:
File System (Local/Network)
Target version:
Start date:
Due date:
% Done:

0%

Resolution:
fixed
Affected Version:

Description

You can recreate the error by adding a folder as a favorite in the file browser then using the favorites window to try and access the new entry.

pastebin of error:
http://pastebin.com/GP14zj9L

possible fix in main xbmc:
https://github.com/jhsrennie/xbmc/commit/6fa3af9455a5ee9dd1e71ce98f6166f73c8874f5#xbmc/Util.cpp

Actions #1

Updated by wannabegt4 almost 13 years ago

  • Status changed from New to In Progress

I've noticed that this is only a problem with local paths e.g. f:\games\. smb://foo/bar/ works fine.

Could it be something to do with the backslash vs forward slash or possibly the double backslash in the smb link.

Actions #2

Updated by wannabegt4 almost 13 years ago

If I manually edit my favoutites.XML to remove the ending slash so that it reads "f:\games" instead of "f:\games\" it goes to the correct directory.

Actions #3

Updated by buzz almost 13 years ago

yeh, the easiest fix is to remove the slash at the point it gets added. the last slash before the quote is escaping the quote, which is causing the issue.

Actions #4

Updated by wannabegt4 almost 13 years ago

I tried again using just f:\games\ with no quotes and it works as well. It looks like the fix from mainline does what we need by removing both the beginning and ending quotes but I can't test it currently as I'm not setup to compile since my last OS reinstall.

Could someone add this little bit of code here and see if it fixes the issue?

https://github.com/jhsrennie/xbmc/commit/6fa3af9455a5ee9dd1e71ce98f6166f73c8874f5#xbmc/Util.cpp

Actions #5

Updated by arnova almost 13 years ago

Please give r31068 a try and report back.

Actions #6

Updated by wannabegt4 almost 13 years ago

Nightlies weren't done last night for the xbox. As soon is one is available I'll test it.

Actions #7

Updated by wannabegt4 almost 13 years ago

Good news, bad news. It no longer goes to the non existent " folder but it's still giving the same error:

http://pastebin.com/NdHMNxra

Could we add the rest of the code which has to do with whether or not it's escaped?

Actions #8

Updated by arnova almost 13 years ago

Give r31075 a try. Note that I haven't been able to come up with a proper fix to get rid of the log warning, which is still there.

Actions #9

Updated by arnova almost 13 years ago

  • Status changed from In Progress to Closed
  • Resolution set to fixed

Really fixed in r31077

Actions

Also available in: Atom PDF