Feature #203
closedFeature #204: Port confluence lite to xbmc4xbox
Container.Foldername support throughout the UI
Added by xbs over 12 years ago. Updated over 11 years ago.
100%
Description
Localizable names of the current container foldername via the Container.Foldername infolabel doesn't display the correct label when using "Confluence Lite".
Main XBMC patch:
https://github.com/xbmc/xbmc/pull/73
Updated by buzz over 12 years ago
- Parent task set to #204
added "port confluence" as parent task as this issue is required to be fixed to aid in the skin development.
Updated by buzz over 12 years ago
- Status changed from New to Feedback
- Assignee changed from buzz to xbs
I reworked the patchset for our source - I've not had a chance to test - could you let me know if this works for you
Updated by dom-dxecutioner over 12 years ago
I just tested this particular build and it seems to be working rather nicely.
A few things I've noticed:
TvShows
Clicking on the Genres or Studios does absolutely nothing at all; admittedly, however, I have not rescanned my library to your new database updates, which may be the culprit, but I thought I mentioned it nonetheless.
Library Hub (Library Root)
This will always display "movies" as the folder name; if possible, it should be named something like "Video Library", "Video Hub" or something to that effect.
After clicking on the "playlists", the folder name will always display the name of the last section you enter; that is to say, if the last place I visited was movies, it will show the folder name as movies, if the last place was recently added episodes, it will display recently added episodes
Other than that, this seems to be working rather nicely! My thanks!!!
Wishful Thinking
It would be nice if you had a "Container.ParentFolderName" label so that we would use it like so:
<control type="label">
<label>$INFO[Container.ParentFolderName] - $INFO[Container.FolderName]</label>
</control>
Assuming we're looking at movies by genres, this would display Genres - Animation
Again, wishful thinking... many thanks for taking the time to do this. :)
Updated by buzz over 12 years ago
If you can get the parentfoldername in xbmc mainline we have a chance to backport it. I dont have the time to add features like this.
Are the issues you have pointed out directly related to the Container.Foldername or just general observations? I would prefer to keep this bug specifically about the ContainerName feature.
Updated by dom-dxecutioner over 12 years ago
After clicking on the "playlists", the folder name will always display the name of the last section you enter; that is to say, if the last place I visited was movies, it will show the folder name as movies, if the last place was recently added episodes, it will display recently added episodes
The above is Container.FolderName specific!
Updated by buzz over 12 years ago
are you saying that is a bug, or the behaviour has changed since this build? That's what I meant - I'm already getting confused as I'm addressing a specific issue regarding the database IDs appearing for foldernames. If your playlists folder name issue is something that has changed since the new build here, then ill look into it. if its just another naming issue, then this is the wrong place, and a new bug should be opened.
Updated by xbs over 12 years ago
buzz wrote:
I reworked the patchset for our source - I've not had a chance to test - could you let me know if this works for you
I'll give it a try as soon as I get a change.
Thank you so much BuZz.
Updated by dom-dxecutioner over 12 years ago
buzz wrote:
are you saying that is a bug, or the behaviour has changed since this build? That's what I meant - I'm already getting confused as I'm addressing a specific issue regarding the database IDs appearing for foldernames. If your playlists folder name issue is something that has changed since the new build here, then ill look into it. if its just another naming issue, then this is the wrong place, and a new bug should be opened.
Ok... as far as the database ID' are concerned, they are working perfectly; i've tested the movies, the tvshows, and the music library and thus far Container.FolderName does, indeed, display the correct names, i.e. genres, artists, artist's names, actors, actor's names. Brilliant!
I suppose this would be more of a bug that perhaps is inherited from the main branch!
For all intents and purposes, your changes are working beatifully!
Updated by buzz over 12 years ago
Thanks. I will wait on xbs to also test, and if he thinks it is ok, I can push these source changes in, then I can explore the playlist name issue on another ticket. Worth also checking if the behaviour is the same in xbmc mainline or specific to us.
Updated by xbs over 12 years ago
Noticed two issues so far that one affect us (Xbox)...
1. Entering Video Files displays as "Video" and Video Library as "Videos". Music Files shows up as "Music Files" and Music Library as "Music Library". (not a big deal but it would be nice to have consistency).
2. The sub node label isn't cleared after going back to root. e.g. First time we enter video library, after boot, the label displayed is "Videos", if we enter the "Movies" node the label changes to "Videos - Movies", but when we go back to root (Videos) the label displayed remains "Videos - Movies" and it shouldn't. It should be clearer back to "Videos".
Updated by buzz over 12 years ago
I will look into it. how are you testing btw - with your beta confluence lite? I'm assuming I'll need that to debug?
Updated by xbs over 12 years ago
Yes, I've sent you a PM with the link to download the test skin.
Updated by buzz over 12 years ago
xbs wrote:
Noticed two issues so far that one affect us (Xbox)...
1. Entering Video Files displays as "Video" and Video Library as "Videos". Music Files shows up as "Music Files" and Music Library as "Music Library". (not a big deal but it would be nice to have consistency).
this is partly a skin issue - check in skin xml MyVideonav.xml
where you have
<label>$LOCALIZE[3]</label>
you can change it to
<label>$LOCALIZE[20314]</label>
2. The sub node label isn't cleared after going back to root. e.g. First time we enter video library, after boot, the label displayed is "Videos", if we enter the "Movies" node the label changes to "Videos - Movies", but when we go back to root (Videos) the label displayed remains "Videos - Movies" and it shouldn't. It should be clearer back to "Videos".
im currently looking into these issue.
Updated by buzz over 12 years ago
I have made some changes - Will post a build in a mo:
Adding Container.FolderName for plugin://video and plugin://music paths - the returned name is "Plugins"
When at the root of Music / Video library the Container.FolderName is cleared. This fixes the 2nd part of your report.
Updated by buzz over 12 years ago
Build is updated - same link as before. thanks - note it includes an additional language string not just the default.xbe
Updated by buzz over 12 years ago
Also note
ActivateWindow(Programs,Plugins,return)
doesn't work in this build but will be fixed.
Updated by xbs over 12 years ago
buzz wrote:
xbs wrote:
Noticed two issues so far that one affect us (Xbox)...
1. Entering Video Files displays as "Video" and Video Library as "Videos". Music Files shows up as "Music Files" and Music Library as "Music Library". (not a big deal but it would be nice to have consistency).
this is partly a skin issue - check in skin xml MyVideonav.xml
where you have
[...]you can change it to
[...]
2. The sub node label isn't cleared after going back to root. e.g. First time we enter video library, after boot, the label displayed is "Videos", if we enter the "Movies" node the label changes to "Videos - Movies", but when we go back to root (Videos) the label displayed remains "Videos - Movies" and it shouldn't. It should be clearer back to "Videos".
im currently looking into these issue.
Of course it is a skin issue, how could I miss that!? :)
I'll test it tonight and report back.
Cheers!
Updated by xbs over 12 years ago
Tested the new build and the labels seem to be working very well.
ActivateWindow(Pictures,Plugins,return) isn't working, could you take a look it too?
Thanks BuZz
Updated by buzz over 12 years ago
- Status changed from Feedback to Resolved
ActivateWindow(Pictures,Plugins,return) support added in r31147
Build will be up in nightlies area shortly. Marking as resolved (and will close later should no further issues arise).
Updated by buzz over 11 years ago
2. The sub node label isn't cleared after going back to root. e.g. First time we enter video library, after boot, the label displayed is "Videos", if we enter the "Movies" node the label changes to "Videos - Movies", but when we go back to root (Videos) the label displayed remains "Videos - Movies" and it shouldn't. It should be clearer back to "Videos".
this was still an ongoing issue, which is finally fixed in r31680