Bug #217
closedIMDB Scraper Function for option "Enable full cast credits"
100%
Description
More Details in this thread:
http://www.xbmc4xbox.org.uk/forum/viewtopic.php?f=9&t=431
The imdb.xml in the common folder is missing a function for fetching the
"Full cast credits" when this option is enabled in the IMDB scraper.
The result, if this option is used, is no CAST is fetched.
Per default, this option is disabled.
As a solution, a new function GetIMDBFullCast has been introduced to the file.
The function was taken from the XBMC mainline where it is named ParseIMDBFullCast.
The DIFFs for the 2 updated files against the ones delivered with the
3.2 release (same as the most recent ones on the trunk).
The DIFFs are also attached as files.
File: system/scrapers/video/common/imdb.xml
DIFF:
diff XBMC4XBOX-3.2-STABLE/system/scrapers/video/common/imdb.xml Update/system/scrapers/video/common/imdb.xml
51a52,65
<GetIMDBFullCast dest="5">
<RegExp input="$$2" output="<details>\1</details>" dest="5">
<RegExp input="$$1" output="\1" dest="6">
<expression noclean="1"><table class="cast">(.*?)</table></expression>
</RegExp>
<RegExp input="$$6" output="<actor><thumb>\1_SX512_SY512_\2</thumb><name>\3</name><role>\5</role></actor>" dest="7">
<expression repeat="yes" clear="yes" fixchars="3,5" trim="3,5" noclean="1,2"><img src="(?:([^"]*\.)[^"]*(\.jpg))?[^>]*[^"]*"nm"><a href="[^"]*[^>]*>([^<]*)<[^"]*"ddd">([^<]<)?[^"]*"char">(.*?)</td></expression>
</RegExp>
<RegExp input="$$7" output="<actor><thumb>\1</thumb>\2</actor>" dest="2+">
<expression repeat="yes" clear="yes" noclean="1,2,3"><actor><thumb>(?:(http.*?)|_SX[0-9]+_SY[0-9]+_)</thumb>(.*?)</actor></expression>
</RegExp>
<expression noclean="1" />
</RegExp>
</GetIMDBFullCast>
Furthermore, the imdb.xml of the scraper has been updated to use the function in case
the option is enabled.
File: system/scrapers/video/imdb.xml
DIFF:
diff XBMC4XBOX-3.2-STABLE/system/scrapers/video/imdb.xml Update/system/scrapers/video/imdb.xml
123c123
< <RegExp conditional="fullcredits" input="$$2" output="<url cache="$$2-fullcredits.html" function="GetIMDBCast">$$3fullcredits</url>" dest="5+">
---
<RegExp conditional="fullcredits" input="$$2" output="<url cache="$$2-fullcredits.html" function="GetIMDBFullCast">$$3fullcredits</url>" dest="5+">
I have tested the moviescraper with both options (Full cast en- and disabled)
and everything seems to work fine now.
Files
Updated by buzz about 12 years ago
please note diffs should be supplied in "unified format". This should be done from a trunk svn checkout, so changes can be applied with a single operation and it makes patches more readable. "svn diff" from the root of trunk would give the required output.
Updated by buzz about 12 years ago
I am unable to apply the patches in their current format. are you running windows or linux - on windows please use the instructions here - http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-patch.html - and all patches should be against the current svn HEAD
Updated by Indy about 12 years ago
- File imdb-patch.diff imdb-patch.diff added
Patch created with Tortoise.
Updated by buzz almost 12 years ago
- Affected Version set to 3.2
finally getting around to looking at this. it seems to me, that we just need to fix up the existing GetIMDBCast function which was broken, rather than making a new one - ie. your code should replace the current IMDBCast. Anyway, I'm going to sync up with imdb for xbmc mainline, so it should fix this up plus right now scraping doesn't seem to be working at all.
Updated by buzz almost 12 years ago
you are actually probably right that there should have been a full cast and non full cast functionality, or perhaps in the past a single function managed both but can no longer due to site changes. I might have to do the same for directors/writers also.
Updated by buzz almost 12 years ago
- Status changed from Feedback to Closed
- % Done changed from 0 to 100
- Resolution set to fixed
imdb scraper updated in r31686 (until next time it breaks). thanks for the heads up regarding full cast. Updated full cast is included amongst other fixes.