Bug #251
closed
Home screen music addon shortcuts failing
0%
Description
just like the video addon shortcuts did before dan fixed it see
http://www.xbmc4xbox.org.uk/forum/viewtopic.php?f=6&t=1599&p=13820&hilit=+addon+shortcut#p13820
well last night i installed tunein radio from a4x repo and set the shortcut and guess what... it does the same as the videos used to as in...
power on xbox
click music addon shortcut
it will fail with a script error
launch if from plugins directory
then go home screen and launch shortcut
it will work
its exactly the same as what the videos were doing
Files
Updated by dandar3 over 11 years ago
- Category set to Python Code and/or Scripts
This is probably due to the fact that id = plugin.audio.tuneinradio while it is stored in Q:\plugins\music\tunein radio\ (notice the space).
A workaround / fix is probably to rename the plugin from "tunein radio" to "TuneInRadio".
Updated by dandar3 about 11 years ago
Aside from the space in the folder, I think there is a problem converting the id into plugin:// path - it appears it tries plugin://audio where in fact it should probably be plugin://music. It works in direct launch as it has a "cwd" value (plugin://music/TuneIn Radio) where in shortcut launch "cwd" is blank and has to determine it from id (plugin.audio.tuneinradio).
15:21:37 M: 29425664 DEBUG: xbmcaddon: cwd =
15:21:37 M: 29425664 DEBUG: xbmcaddon: id = plugin.audio.tuneinradio
15:21:37 M: 29425664 DEBUG: xbmcaddon: locations = ['Q:\\scripts\\.modules\\plugin.audio.tuneinradio', 'plugin://audio/tuneinradio']
15:21:37 M: 29425664 DEBUG: xbmcaddon: trying Q:\scripts\.modules\plugin.audio.tuneinradio
15:21:37 M: 29425664 DEBUG: xbmcaddon: could not open Q:\scripts\.modules\plugin.audio.tuneinradio\addon.xml
15:21:37 M: 29425664 DEBUG: xbmcaddon: trying Q:\plugins\audio\tuneinradio
15:21:37 M: 29425664 DEBUG: xbmcaddon: could not open Q:\plugins\audio\tuneinradio\addon.xml
A solution would be to change the locations logic in xbmcaddon.py to switch from "audio" to "music" - will try that later and provide a patch.
Updated by dandar3 about 11 years ago
- File xbmcaddon.py xbmcaddon.py added
- File xbmcaddon.py.patch xbmcaddon.py.patch added
- Subject changed from home screen music addon shortcuts failing to Home screen music addon shortcuts failing
I believe this will do it (see attachments).
Fixes the "audio" vs "music" location, doesn't do anything for the "tuneinradio" vs "TuneIn Radio" problem. I see this as a naming convention problem, where maybe the plugin should be named with dots where spaces are (e.g. plugin.audio.tunein.radio - aren't some mainline addons named like that?) and then we could handle and convert from "tunein.radio" to "TuneIn Radio".
Updated by buzz about 11 years ago
- Status changed from New to Closed
- Target version set to 3.5
- Resolution set to fixed
fixed in r32598 - thanks Dan.