Project

General

Profile

Actions
Copy link

Bug #267

closed

Compiler warning

Added by dandar3 about 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Low
Assignee:
buzz
Category:
Other (un-categorized)
Target version:
3.5
Start date:
21/11/2013
Due date:
% Done:

100%

Resolution:
fixed
Affected Version:
3.3.3

Description

Noticed a few compiler warnings during build, this is a patch for one of them (you choice whether to keep the ticket for this one and close or re-use for more).

xbmc\SmartPlaylist.cpp(575) : warning C4800: 'CDatabase *' : forcing value to bool 'true' or 'false' (performance warning)

Files

SmartPlaylist.cpp.patch (698 Bytes) SmartPlaylist.cpp.patch fix: incorrect argument order in SmartPlaylist.GetWhereClause() call - fix compiler warning: xbmc\SmartPlaylist.cpp(575) : warning C4800: 'CDatabase *' : forcing value to bool 'true' or 'false' (performance warning) dandar3, 21/11/2013 12:38 AM
Actions
Copy link
 #1

Updated by buzz almost 11 years ago

  • Status changed from New to Closed
  • Assignee set to buzz
  • Target version changed from Future / Pending to 3.5
  • % Done changed from 0 to 100
  • Resolution set to fixed

thanks. fixed in r32646. Please open new tickets for any further warning fixes (I know there are plenty). this was was more important than others, as technically as the wrong parameter order meant it was actually broken. Feel free to include a fix for multiple warnings on a single ticket though.

Actions
Copy link

Also available in: Atom PDF