Bug #271
closed
Plugin > Settings > Folder browse - showing duplicate drive entries
0%
Description
Steps to replicate the issue: go to "Plugin Settings" for a plugin that uses a "type=folder" entry in its settings.xml (e.g. XBMC4Xbox Installer program plugin), then use that to navigate all the way up - you will notice then the duplicate drive entries. Screenshot attached.
Code in question may be in VECSOURCES *CSettings::GetSourcesFromType() in Settings.cpp for "files" type, where it seems to bring the Files then the local drives localized (?!)
Files
Updated by buzz over 10 years ago
fixed in r32651
So our GetSourcesFromType was adding local drives, which was old behaviour. since then some merges from upstream added code to always add local drives to plugin dialog for folders, so they were added twice. removal of the code from Settings.cpp to match upstream meant no local drives showed by default in the file manager. I just specifically added them in that piece of code, as I think GetSourcesFromType should not do any magic like adding local drives (and we want to match upstream where we can). There might be other areas I have missed where there is an assumption that GetSourcesFromType for files will add local folders, but if so we can fix them up - feel free to give this some testing etc and let me know if I have missed something.
Updated by buzz over 10 years ago
- Category set to Other (un-categorized)
- Status changed from New to Closed
- Assignee set to buzz
- Target version set to 3.5
- Resolution set to fixed
Updated by buzz over 10 years ago
- Status changed from Closed to New
- Resolution deleted (
fixed)
Looks like there are issues with my fix. Need to revisit.
Updated by buzz over 10 years ago
- Status changed from New to Resolved
- Resolution set to fixed