Bug #285
closed
X3 LCD not displaying app/game after launch
0%
Description
Can the below line be removed to make the game/app name stay on the LCD after launch?
Seem to have no unwanted side effects on my xbox with this line removed.
Thank you.
Line 3951, Util.cpp
#ifdef HAS_XBOX_HARDWARE
// g_application.Stop(); // Brent - Removed to make Playing *** stay on LCD
CUtil::LaunchXbe(szDevicePath, szXbePath, szParameters, ForceVideo, ForceCountry, pData);
#endif
Updated by buzz about 10 years ago
- Status changed from New to Feedback
- Assignee set to brentdc42
Thanks, although I think we need to look further into this as Stop() does a lot of useful things such as cleanly shutting down services, stopping background scraper jobs, and python etc. Check out Application.cpp around line 3497 and instead perhaps try commenting out the code to stop the LCD thread - line 3564. if that works, we can then allow a parameter to be sent to the stop function, so tell it not to stop the LCD thread for example.
Updated by brentdc42 about 10 years ago
Thanks for the advice Buzz.
Commenting out the code on line 3564 in applications worked keeping the lcd text there as you suggested, the following code worked for me to keep the lcd text but shut down the other services.
I am new to programming so hopefully this isn't to ugly.
Util.cpp Line 3951
#ifdef HAS_XBOX_HARDWARE
g_application.Stop(true); //Brent - True makes lcd "Playing ***" message stay.
CUtil::LaunchXbe(szDevicePath, szXbePath, szParameters, ForceVideo, ForceCountry, pData);
#endif
Application.h Line 99
void Stop(bool lcdstop); //Brent
Application.cpp Line 3497
void CApplication::Stop(bool lcdstop) //Brent
{
Application.cpp Line 3564
#ifdef HAS_LCD
if (lcdstop != true) //Brent
{
if (g_lcd)
{
g_lcd->Stop();
delete g_lcd;
g_lcd=NULL;
}
} //Brent end
#endif
ApplicationMessenger.cpp
Line 169
g_application.Stop(false); //Brent
Line 240
g_application.Stop(false); //Brent
Line 256
g_application.Stop(false); //Brent
Updated by brentdc42 about 10 years ago
EDIT: Probably would have made more sense to call the boolean variable ignore_lcd_stop
Updated by buzz about 10 years ago
I will work on a fix similar to this. However if contributing code you actually want in the project, please provide a diff/patch file.
assuming you are using windows - http://tortoisesvn.net/docs/nightly/TortoiseSVN_en/tsvn-dug-patch.html
Updated by buzz almost 10 years ago
- Status changed from Feedback to Closed
- Resolution set to fixed
I have changed the behaviour of this in r32721.