Project

General

Profile

Actions

Bug #306

closed

Clear weather wont show icon

Added by notthesame over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Weather forecasts
Target version:
Start date:
05/27/2014
Due date:
% Done:

0%

Resolution:
fixed
Affected Version:

Description

when it presents Clear in my Weather my icons wont I tried other changing my Weather to realistic but still same thing also different skins.

this started with 3.5.2 and I had updated to 3.5.3 and now use 3.5.4 with same issue.
i already tired to reinstall xbmc4xbox and got newest weather same issue conintues.

heres my log
http://pastebin.com/Q5h9bkzG

thank you guys :)


Files

xmlcomparison.jpg (173 KB) xmlcomparison.jpg brentdc42, 07/01/2014 03:35 AM
Weather.cpp.patch (571 Bytes) Weather.cpp.patch brentdc42, 07/01/2014 03:36 AM
screenshot001.jpg (212 KB) screenshot001.jpg brentdc42, 07/01/2014 04:05 AM

Updated by brentdc42 over 10 years ago

I found that the API has changed so the XML no longer returns the string "N/A" it now returns nothing i.e. "" (XML comparison pic attached). So with a very simple change the weather icon for N/A is now working fine for me.

GetString(pElement, "icon", iTmpStr, "");
if (iTmpStr "")
// if (iTmpStr "N/A")
m_currentIcon.Format("%s128x128/na.png", WEATHER_BASE_PATH);

Actions #2

Updated by brentdc42 over 10 years ago

By the way I'm referring to the <icon></icon> field in the XML, not the <t></t> field. So I guess that means that the icon field used to return <icon>N/A</icon> as well.

Actions #4

Updated by buzz over 10 years ago

  • Category set to Weather forecasts
  • Status changed from New to Closed
  • Assignee set to buzz
  • Target version set to 3.5
  • Resolution set to fixed
  • Affected Version changed from 3.3.2 to 3.5

Thanks brentdc42. Your fix has been applied in r32871.

Actions

Also available in: Atom PDF