Project

General

Profile

Feature #314

HTTP API GetShares() - allow for "programs" type

Added by dandar3 over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Server / Web Interface
Target version:
Start date:
08/09/2014
Due date:
% Done:

100%

Resolution:
fixed

Description

HTTP API GetShares() to allow for "programs" type - useful to identify "Emulators" and "Games" source locations.

Patch file attached, thanks.


Files

test_getshares.py (117 Bytes) test_getshares.py dandar3, 08/09/2014 03:09 PM
XBMChttp.cpp.patch (1.09 KB) XBMChttp.cpp.patch dandar3, 08/18/2014 08:30 PM

Associated revisions

Revision 32872 (diff)
Added by buzz over 5 years ago

added: HTTP API GetShares() - allow for "programs" type - thanks to dan dar3. #314

History

#1

Updated by buzz over 5 years ago

  • Status changed from New to Feedback
  • Assignee set to dandar3

looks good, but is there any specific reason you inserted it in the middle of the else if and before FILES in parameter ordering rather than appending it ? Makes the patchset/changeset more readable that way.

#2

Updated by buzz over 5 years ago

When I said parameter ordering, I meant inserting it before FILES in the enumeration, rather than adding it to the end. (apologise for poor wording)

#3

Updated by dandar3 over 5 years ago

Thought "programs" were a bit "smarter" than "files", not important though.
Updated patch attached.

#4

Updated by dandar3 over 5 years ago

  • File deleted (XBMChttp.cpp.patch)
#5

Updated by buzz over 5 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100
  • Resolution set to fixed

applied in r32872. Thanks

Also available in: Atom PDF