Project

General

Profile

Actions

Feature #334

open

Auto generate video thumbnails

Added by brentdc42 about 10 years ago. Updated about 10 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/23/2014
Due date:
% Done:

0%

Resolution:

Description

Hi have attached a small patch to auto generate video thumbnails. As extracting video information is not used I assume it's fine to comment the CStreamDetails argument in the CDVDFileInfo::ExtractThumb function?

This patch may need some tweaking as I'm still novice.

Thank you


Files

AutoGenVideoThumbs.patch (3.26 KB) AutoGenVideoThumbs.patch brentdc42, 10/23/2014 01:17 PM
Actions #1

Updated by buzz about 10 years ago

Appreciate the patch but it isn't needed and would require cleanup anyway (whitespace and indentation issues / commented out sections etc). I would prefer to look into this myself when I have the time (thumbnail extraction is not broken - it was intentionally disabled so I don't require patches to re-enable). cheers.

Actions #2

Updated by buzz about 10 years ago

just FYI - If I do decide to enable it (as an option) - I will do it something like r23068 (but move it to the job manager)

Actions #3

Updated by buzz about 10 years ago

(sorry it's only part of that patch - basically re-adding what was removed in r23070 and r24838)

Actions #4

Updated by brentdc42 about 10 years ago

No worries, thanks for the info on where it was originally removed.

Actions

Also available in: Atom PDF