Project

General

Profile

Actions

Bug #365

open

Propose for Weather Fix

Added by antonic901 over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
Category:
Weather forecasts
Target version:
Start date:
12/24/2022
Due date:
% Done:

0%

Resolution:
Affected Version:

Description

Here is a fix for weather. I've implemented new API (weatherapi.com) and added inside CallPLugin method (GUIWeather.cpp) to pass also location index when calling plugin. This will allow plugin to fetch new weather when user change location from Weather window.


Files

weather-fix.patch (20.6 KB) weather-fix.patch antonic901, 12/24/2022 04:41 PM
weather-fix.patch (21.8 KB) weather-fix.patch antonic901, 12/24/2022 07:08 PM
weather-fix.patch (22 KB) weather-fix.patch antonic901, 12/25/2022 02:10 PM
weather-fix.patch (20.8 KB) weather-fix.patch antonic901, 01/14/2023 05:41 PM
Actions #2

Updated by antonic901 over 1 year ago

Added initialization of m_lastUpdateTime before plugin gets executed. This will set infolabel Weather.IsFetched to true.

Actions #3

Updated by buzz over 1 year ago

  • Priority changed from Immediate to Normal

Thanks for this.

Please can you fix the formatting for this also. You have tab indentation so the files end up with mixed indent. (Make sure to use the same line endings as the files you are editing too).

Old / unused code also should be removed and not commented out. This isn't needed since we are using source control.

Actions #4

Updated by antonic901 over 1 year ago

Removed commented code and fixed indetation.

Actions

Also available in: Atom PDF