Project

General

Profile

Actions
Copy link

Bug #129

closed

Season Thumbs no longer independent from tv show banner

Added by craigey over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
arnova
Category:
Other (un-categorized)
Target version:
3.0
Start date:
Due date:
% Done:

0%

Resolution:
fixed
Affected Version:

Description

This is a full list of everything I have done to recreate the issue & create the debug log.
I have just gone in & checked the settings of the scraper for the tv show glee & checked that posters were enabled (they were). Then gone to library mode & gone to 'TV show information' -> 'Refresh' -> For all episodes = yes. After that had finished I went in to Glee & saw the season thumbs were set to the same as the banner. I then went back the tv show list & 'TV show information' -> 'get thumb' & selected the banner I wanted. I went back to the season list & the season thumbs are now the same as the new banner.

I've posted my debug xbmc.log on http://pastebin.org/171179

but just wondering if these might have anything to do with the issue?

<thumb type="season" season="-1">
...
...
13:58:59 M: 39952384 WARNING: DIRECTORY::CVideoDatabaseDirectory::GetIcon - Unknown nodetype requested videodb://2/2/46/1/
13:58:59 M: 39952384 WARNING: DIRECTORY::CVideoDatabaseDirectory::GetIcon - Unknown nodetype requested videodb://2/2/46/2/

I presume the /1/ = season 1 & /2/ = season 2??

Actions
Copy link
 #1

Updated by arnova over 13 years ago

Any idea what the last revision was this problem didn't have?

Actions
Copy link
 #2

Updated by craigey over 13 years ago

Replying to [comment:1 arnova]:

Any idea what the last revision was this problem didn't have?

The previous version i was using was SVN: 30439, so I can only say it's somewhere between the two.

Actions
Copy link
 #3

Updated by craigey over 13 years ago

This issue was also reported on xbmc.org. It appears that due to a change in thetvdb scraper season thumbs aren't being picked up.
A user 'Krazeh' on xbmc.org forums posted a fix which I have tested & it does appear to fix the issue:

edit the file system\scrapers\video\tvdb.xml
find

<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;season&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;$INFO[language]&lt;/Language&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>
<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;season&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;[a-z][^$INFO[language]]*&lt;/Language&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>
<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;seasonwide&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;$INFO[language]&lt;/Language&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>
<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;seasonwide&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;[a-z][^$INFO[language]]*&lt;/Language&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>

replace with

<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;season&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;$INFO[language]&lt;/Language&gt;[^&lt;]*&lt;Rating&gt;[^&lt;]*&lt;/Rating&gt;[^&lt;]*&lt;RatingCount&gt;[^&lt;]*&lt;/RatingCount&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>
<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;season&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;[a-z][^$INFO[language]]*&lt;/Language&gt;[^&lt;]*&lt;Rating&gt;[^&lt;]*&lt;/Rating&gt;[^&lt;]*&lt;RatingCount&gt;[^&lt;]*&lt;/RatingCount&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>
<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;seasonwide&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;$INFO[language]&lt;/Language&gt;[^&lt;]*&lt;Rating&gt;[^&lt;]*&lt;/Rating&gt;[^&lt;]*&lt;RatingCount&gt;[^&lt;]*&lt;/RatingCount&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>
<RegExp input="$$5" output="&lt;thumb type=&quot;season&quot; season=&quot;\2&quot;&gt;http://thetvdb.com/banners/\1&lt;/thumb&gt;" dest="4+">
    <expression repeat="yes">&lt;BannerPath&gt;([^&lt;]*)&lt;/BannerPath&gt;[^&lt;]*&lt;BannerType&gt;season&lt;/BannerType&gt;[^&lt;]*&lt;BannerType2&gt;seasonwide&lt;/BannerType2&gt;[^&lt;]*&lt;Language&gt;[a-z][^$INFO[language]]*&lt;/Language&gt;[^&lt;]*&lt;Rating&gt;[^&lt;]*&lt;/Rating&gt;[^&lt;]*&lt;RatingCount&gt;[^&lt;]*&lt;/RatingCount&gt;[^&lt;]*&lt;Season&gt;([0-9]+)&lt;/Season&gt;</expression>
</RegExp>

I'd be greatful if someone could add this to SVN. I could do it, but don't want to break anything!
Thanks.

Actions
Copy link
 #4

Updated by arnova over 13 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by arnova over 13 years ago

  • Status changed from In Progress to Closed
  • Resolution set to fixed

r30696. Thanks for the fix. Please provide a patch/diff next time, if possible....

Actions
Copy link

Also available in: Atom PDF