Bug #129
closed
Season Thumbs no longer independent from tv show banner
Added by craigey about 14 years ago.
Updated about 14 years ago.
Category:
Other (un-categorized)
Description
This is a full list of everything I have done to recreate the issue & create the debug log.
I have just gone in & checked the settings of the scraper for the tv show glee & checked that posters were enabled (they were). Then gone to library mode & gone to 'TV show information' -> 'Refresh' -> For all episodes = yes. After that had finished I went in to Glee & saw the season thumbs were set to the same as the banner. I then went back the tv show list & 'TV show information' -> 'get thumb' & selected the banner I wanted. I went back to the season list & the season thumbs are now the same as the new banner.
I've posted my debug xbmc.log on http://pastebin.org/171179
but just wondering if these might have anything to do with the issue?
<thumb type="season" season="-1">
...
...
13:58:59 M: 39952384 WARNING: DIRECTORY::CVideoDatabaseDirectory::GetIcon - Unknown nodetype requested videodb://2/2/46/1/
13:58:59 M: 39952384 WARNING: DIRECTORY::CVideoDatabaseDirectory::GetIcon - Unknown nodetype requested videodb://2/2/46/2/
I presume the /1/ = season 1 & /2/ = season 2??
Any idea what the last revision was this problem didn't have?
Replying to [comment:1 arnova]:
Any idea what the last revision was this problem didn't have?
The previous version i was using was SVN: 30439, so I can only say it's somewhere between the two.
This issue was also reported on xbmc.org. It appears that due to a change in thetvdb scraper season thumbs aren't being picked up.
A user 'Krazeh' on xbmc.org forums posted a fix which I have tested & it does appear to fix the issue:
edit the file system\scrapers\video\tvdb.xml
find
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>season</BannerType2>[^<]*<Language>$INFO[language]</Language>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>season</BannerType2>[^<]*<Language>[a-z][^$INFO[language]]*</Language>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>seasonwide</BannerType2>[^<]*<Language>$INFO[language]</Language>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>seasonwide</BannerType2>[^<]*<Language>[a-z][^$INFO[language]]*</Language>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
replace with
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>season</BannerType2>[^<]*<Language>$INFO[language]</Language>[^<]*<Rating>[^<]*</Rating>[^<]*<RatingCount>[^<]*</RatingCount>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>season</BannerType2>[^<]*<Language>[a-z][^$INFO[language]]*</Language>[^<]*<Rating>[^<]*</Rating>[^<]*<RatingCount>[^<]*</RatingCount>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>seasonwide</BannerType2>[^<]*<Language>$INFO[language]</Language>[^<]*<Rating>[^<]*</Rating>[^<]*<RatingCount>[^<]*</RatingCount>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
<RegExp input="$$5" output="<thumb type="season" season="\2">http://thetvdb.com/banners/\1</thumb>" dest="4+">
<expression repeat="yes"><BannerPath>([^<]*)</BannerPath>[^<]*<BannerType>season</BannerType>[^<]*<BannerType2>seasonwide</BannerType2>[^<]*<Language>[a-z][^$INFO[language]]*</Language>[^<]*<Rating>[^<]*</Rating>[^<]*<RatingCount>[^<]*</RatingCount>[^<]*<Season>([0-9]+)</Season></expression>
</RegExp>
I'd be greatful if someone could add this to SVN. I could do it, but don't want to break anything!
Thanks.
- Status changed from New to In Progress
- Status changed from In Progress to Closed
- Resolution set to fixed
r30696. Thanks for the fix. Please provide a patch/diff next time, if possible....
Also available in: Atom
PDF