Project

General

Profile

Bug #358

XBMC.PlayMedia() built-in > video playback resuming even when configured not to

Added by Rocky5 about 3 years ago. Updated about 2 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
Video playback (inc. audio in
Target version:
Start date:
06/29/2016
Due date:
% Done:

0%

Resolution:
Affected Version:

Description

"Settings > Video > Playback > Resume from where last stopped" - Set to No, doesn't seem to work as intended. Yes and Ask works fine, but No will still resume a video from where it was stopped/resume point was created.


Files

Builtins.cpp.variantA.patch (2.02 KB) Builtins.cpp.variantA.patch dandar3, 10/10/2016 10:21 PM
Builtins.cpp.variantB.patch (1.96 KB) Builtins.cpp.variantB.patch dandar3, 10/10/2016 10:21 PM

History

#1

Updated by dandar3 about 3 years ago

  • Subject changed from Video file resume playback no setting doesn't work. to Video "Resume from where last stopped" = NO setting doesn't behave as expected
#2

Updated by dandar3 about 3 years ago

  • Assignee set to dandar3
#3

Updated by dandar3 almost 3 years ago

Finally I think we identified the problem in Builtins.cpp where askToResume is set to true by default (when not overridden through additional parameters), that makes later logic to call CGUIWindowVideoBase::OnResumeShowMenu() which sets the item resume flag to resume.

Attaching a fix to default askToResume to the correct default value based on whether the system setting videoplayer.resumeautomatically is set to RESUME_ASK as it should really.

Unfortunatelly the call to CGUIWindowVideoBase::OnResumeShowMenu() was also making it resume correctly when the system was configured to resume automatically(RESUME_YES), so I had to introduce a second variable to make that case work as expected.

That looked a bit harder to understand so I've also attached a second version that uses a single int variable instead of the two booleans. Please feel free to choose or change as you see fit.

#4

Updated by dandar3 about 2 years ago

  • Assignee changed from dandar3 to buzz

Also available in: Atom PDF